Bug 156576 – [ES7] yield star should not return if the inner iterator.throw returns { done: true }

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[ES6] yield star should not return if the inner iterator.throw returns { done: true }

[Yusuke Suzuki]

Created attachment 276391 [details]
Patch

[Yusuke Suzuki]

This change is also listed here. http://kangax.github.io/compat-table/esnext/

[Yusuke Suzuki]

Created attachment 276395 [details]
Patch

[Yusuke Suzuki]

Created attachment 276396 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 276396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276396&action=review

> Source/JavaScriptCore/builtins/GeneratorPrototype.js:83
> +    return @generatorResume(this, exception, @GeneratorResumeModeThrow);

Use bytecode intrinsic constants. We can keep in sync with JSGenerator::constants.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4442
> +                    emitThrowTypeError(ASCIILiteral("Iterator result interface is not an object."));

When innerIterator.throw() does not throw, we fall into the usual iteration path (branchOnResult).

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4491
> +            emitLabel(branchOnResult.get());

The iterator loop's condition phase.

[Yusuke Suzuki]

Note that this is not staging change. It is already introduced into the spec draft (ECMAScript 2016 spec).

[Darin Adler]

Comment on attachment 276396 [details]
Patch

Looks OK to me, but it’s slightly outside my expertise which is why I am not marking it review+

[Saam Barati]

Comment on attachment 276396 [details]
Patch

r=me

[Yusuke Suzuki]

Comment on attachment 276396 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 276396 [details]
Patch

Clearing flags on attachment: 276396

Committed r199652: <http://trac.webkit.org/changeset/199652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.