...
Created attachment 276374 [details] WIP this might work. I haven't tested it thoroughly. Still needs FTL support.
Created attachment 276375 [details] WIP
Created attachment 276601 [details] patch
Attachment 276601 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOperations.h:154: The parameter name "scope" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7837: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/parser/Parser.h:997: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/parser/Parser.h:1001: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:69: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:71: One space before end of line comments [whitespace/comments] [5] Total errors found: 6 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276619 [details] patch fix 64bit rebase compilation
Attachment 276619 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOperations.h:154: The parameter name "scope" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7837: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/parser/Parser.h:997: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/parser/Parser.h:1001: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:69: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:71: One space before end of line comments [whitespace/comments] [5] Total errors found: 6 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 276619 [details] patch Attachment 276619 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1178305 New failing tests: js/dom/dfg-put-to-readonly-property.html
Created attachment 276620 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 276619 [details] patch r- due to EWS failure
Created attachment 276656 [details] patch I think this patch should work now. There was a subtle bug where I flushed registers before asking a JSValueOperand for it's GPR which confused the DFG register allocator into thinking a particular register still held a particular value. I also fixed armv7 setupArgumentsWithExecState
Created attachment 276657 [details] patch fix a comment.
Attachment 276657 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOperations.h:154: The parameter name "scope" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/parser/Parser.h:997: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/parser/Parser.h:1001: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:69: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:71: One space before end of line comments [whitespace/comments] [5] Total errors found: 5 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276658 [details] patch remove commented out code.
Attachment 276658 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:69: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:71: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 276658 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=276658&action=review r=me > Source/JavaScriptCore/ChangeLog:17 > + There was a subtle bug where we used to never compile the var injection vartiant of the variant > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2655 > + case UnresolvedProperty: > + case UnresolvedPropertyWithVarInjectionChecks: I think we want to OSR exit on these two types of access because the baseline JIT can gather profiling data that resolves them. To be conservative, you could say "OSR exit on these types, but only if I haven't done so already." Our hope is that the baseline JIT will produce profiling on first access. But if it fails, there's no reason to try again.
Created attachment 276663 [details] patch for landing I've implemented Geoff's suggested heuristic.
Created attachment 276669 [details] patch for landing rebased
Attachment 276669 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:69: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:71: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276680 [details] patch for landing efl build fix.
Attachment 276680 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:69: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/GetPutInfo.h:71: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 276680 [details] patch for landing Clearing flags on attachment: 276680 Committed r199699: <http://trac.webkit.org/changeset/199699>
All reviewed patches have been landed. Closing bug.