Bug 156555 - PolymorphicAccess should try to generate a stub only once
Summary: PolymorphicAccess should try to generate a stub only once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-13 14:01 PDT by Filip Pizlo
Modified: 2016-04-14 16:08 PDT (History)
5 users (show)

See Also:

Attachments
the patch (7.00 KB, patch)
2016-04-14 15:14 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-13 14:01:36 PDT 
Currently, we don't do any buffering of access cases prior to the first stub generation.  We only enable it after a stub has been generated.

I implemented buffering that way to be conservative.  Now we should push it further and always buffer.  The outcome ought to be that most ICs only generate a stub once.
Comment 1 Filip Pizlo 2016-04-14 15:14:01 PDT 
Created attachment 276437 [details]
the patch
Comment 2 Geoffrey Garen 2016-04-14 15:22:04 PDT 
Comment on attachment 276437 [details]
the patch

r=me
Comment 3 Filip Pizlo 2016-04-14 16:08:24 PDT 
Landed in http://trac.webkit.org/changeset/199566