Bug 156552 - Add Web-exposed feature policy page to webkit.org
Summary: Add Web-exposed feature policy page to webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Theresa O'Connor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-13 12:56 PDT by Theresa O'Connor
Modified: 2016-04-14 14:36 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (3.47 KB, patch)
2016-04-13 14:28 PDT, Theresa O'Connor
darin: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
updated patch (3.44 KB, patch)
2016-04-14 13:35 PDT, Theresa O'Connor
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Theresa O'Connor 2016-04-13 12:56:05 PDT
Put the runtime flag / prefixing policy text up on webkit.org somewhere.
Comment 1 Jon Davis 2016-04-13 13:48:11 PDT
I recommend adding Websites/webkit.org/prefix-policy.md first. Then we'll add a page to the CMS to render it.
Comment 2 Theresa O'Connor 2016-04-13 14:28:15 PDT
Created attachment 276354 [details]
proposed patch

This just adds the policy text, it doesn't include wiring it up in the CMS (as Jon suggested in comment 1).
Comment 3 Timothy Hatcher 2016-04-14 12:13:31 PDT
Comment on attachment 276354 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276354&action=review

> Websites/webkit.org/feature-policy.md:1
> +### Web-exposed Feature Policy

This is not neede, as it will be a page title on the page that loads this.

> Websites/webkit.org/feature-policy.md:3
> +#### Runtime flags

IIRC, we use 2 ## for these level of headers.

> Websites/webkit.org/feature-policy.md:55
> +#### Naming

Ditto.
Comment 4 Theresa O'Connor 2016-04-14 12:18:37 PDT
(In reply to comment #3)
> Comment on attachment 276354 [details]
> proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276354&action=review
> 
> > Websites/webkit.org/feature-policy.md:1
> > +### Web-exposed Feature Policy
> 
> This is not needed, as it will be a page title on the page that loads this.

OK. I'll drop it.

As for these:

> > Websites/webkit.org/feature-policy.md:3
> > +#### Runtime flags
> 
> IIRC, we use 2 ## for these level of headers.
> 
> > Websites/webkit.org/feature-policy.md:55
> > +#### Naming
> 
> Ditto.

To match security-policy.md they should use ###s. Fixing that too.
Comment 5 Theresa O'Connor 2016-04-14 13:35:05 PDT
Created attachment 276417 [details]
updated patch
Comment 6 WebKit Commit Bot 2016-04-14 14:36:55 PDT
Comment on attachment 276417 [details]
updated patch

Clearing flags on attachment: 276417

Committed r199555: <http://trac.webkit.org/changeset/199555>
Comment 7 WebKit Commit Bot 2016-04-14 14:36:59 PDT
All reviewed patches have been landed.  Closing bug.