Bug 156548 - We should not speculatively revalidate cached redirects
Summary: We should not speculatively revalidate cached redirects
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2016-04-13 12:34 PDT by Chris Dumez
Modified: 2016-04-13 17:15 PDT (History)
4 users (show)

See Also:

Patch (15.31 KB, patch)
2016-04-13 14:11 PDT, Chris Dumez
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-13 12:34:41 PDT
We should not speculatively revalidate cached redirects. This matches the behavior matches the one in NetworkCache's makeUseDecision() which reuses cached redirects only if it does not need validation.
Comment 1 Chris Dumez 2016-04-13 12:35:11 PDT
Comment 2 Chris Dumez 2016-04-13 14:11:31 PDT
Created attachment 276352 [details]
Comment 3 Darin Adler 2016-04-13 16:48:30 PDT
Comment on attachment 276352 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=276352&action=review

> Source/WebKit2/ChangeLog:22
> +        to do in this case, as we are supposed to do a hand-shake with Webore

Webore -> WebCore

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:69
> +    // We drop speculative revalidations if they redirect for now.

Comments are best when the answer the question "Why?". This comes close but doesn’t quite state why.
Comment 4 Chris Dumez 2016-04-13 17:13:58 PDT
Committed r199521: <http://trac.webkit.org/changeset/199521>