RESOLVED FIXED 156548
We should not speculatively revalidate cached redirects 
https://bugs.webkit.org/show_bug.cgi?id=156548
Summary We should not speculatively revalidate cached redirects
Chris Dumez
Reported 2016-04-13 12:34:41 PDT
We should not speculatively revalidate cached redirects. This matches the behavior matches the one in NetworkCache's makeUseDecision() which reuses cached redirects only if it does not need validation.
Attachments
Patch (15.31 KB, patch)
2016-04-13 14:11 PDT, Chris Dumez 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-04-13 12:35:11 PDT
rdar://problem/25583886
Chris Dumez
Comment 2 2016-04-13 14:11:31 PDT
Created attachment 276352 [details] Patch
Darin Adler
Comment 3 2016-04-13 16:48:30 PDT
Comment on attachment 276352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276352&action=review > Source/WebKit2/ChangeLog:22 > + to do in this case, as we are supposed to do a hand-shake with Webore Webore -> WebCore > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:69 > + // We drop speculative revalidations if they redirect for now. Comments are best when the answer the question "Why?". This comes close but doesn’t quite state why.
Chris Dumez
Comment 4 2016-04-13 17:13:58 PDT
Committed r199521: <http://trac.webkit.org/changeset/199521>
Note You need to log in before you can comment on or make changes to this bug.