Temporarily ignore SecCodeCopyGuestWithAttributes() failure to fix the hang. I fill follow up with a long term fix shortly.
<rdar://problem/25697779>
Created attachment 276332 [details] Patch
Comment on attachment 276332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276332&action=review > Source/WebKit2/Shared/mac/CodeSigning.mm:101 > + RetainPtr<SecCodeRef> code = secCodeForProcess(pid); Can use auto here.
Committed r199504: <http://trac.webkit.org/changeset/199504>
Comment on attachment 276332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276332&action=review > Source/WebKit2/Shared/mac/CodeSigning.mm:58 > + OSStatus errorCode = noErr; > + // FIXME: We should RELEASE_ASSERT() that SecCodeCopyGuestWithAttributes() returns without error. > + if ((errorCode = SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code))) { > + WTFLogAlways("SecCodeCopyGuestWithAttributes() failed with error: %ld\n", static_cast<long>(errorCode)); > + return nullptr; > + } > RELEASE_ASSERT(!SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code)); I don’t think you wanted to call this twice.
(In reply to comment #5) > > Source/WebKit2/Shared/mac/CodeSigning.mm:58 > > [...] > > RELEASE_ASSERT(!SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code)); > > I don’t think you wanted to call this twice. Fixed in <http://trac.webkit.org/changeset/199528>.