Bug 156544 - FindWebP should not be misguided by pkg-config when cross-compiling.
Summary: FindWebP should not be misguided by pkg-config when cross-compiling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-13 09:58 PDT by Konstantin Tokarev
Modified: 2016-04-14 03:26 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2016-04-13 10:00 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2016-04-13 10:31 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-04-13 09:58:11 PDT 
We should use pkg-config output only as a hint, like other modules do.
Comment 1 Konstantin Tokarev 2016-04-13 10:00:42 PDT 
Created attachment 276330 [details]
Patch
Comment 2 Konstantin Tokarev 2016-04-13 10:31:41 PDT 
Created attachment 276331 [details]
Patch
Comment 3 Michael Catanzaro 2016-04-13 10:49:22 PDT 
Comment on attachment 276331 [details]
Patch

By the way, do you have committer access yet? You can stop setting cq? and move it straight to cq+ once you do.
Comment 4 Konstantin Tokarev 2016-04-13 10:57:22 PDT 
Not yet.
Comment 5 WebKit Commit Bot 2016-04-13 15:58:22 PDT 
Comment on attachment 276331 [details]
Patch

Clearing flags on attachment: 276331

Committed r199518: <http://trac.webkit.org/changeset/199518>
Comment 6 WebKit Commit Bot 2016-04-13 15:58:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Carlos Alberto Lopez Perez 2016-04-13 18:06:41 PDT 
Continuous build broke with this.

I have triggered clean builds on all the GTK+ bots.
Comment 8 Konstantin Tokarev 2016-04-14 02:47:10 PDT 
(In reply to comment #7)
> Continuous build broke with this.
> 
> I have triggered clean builds on all the GTK+ bots.

This patch requires one clean build after landing, after that continuous builds should work fine (at least it works in my local tests).
Comment 9 Carlos Alberto Lopez Perez 2016-04-14 03:26:05 PDT 
(In reply to comment #8)
> (In reply to comment #7)
> > Continuous build broke with this.
> > 
> > I have triggered clean builds on all the GTK+ bots.
> 
> This patch requires one clean build after landing, after that continuous
> builds should work fine (at least it works in my local tests).

Yes.

that is what I wanted to say :)