Bug 156543 - REGRESSION: Web Inspector: Remote inspector doesn't work
Summary: REGRESSION: Web Inspector: Remote inspector doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2016-04-13 09:31 PDT by Carlos Garcia Campos
Modified: 2016-04-14 10:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2016-04-14 01:37 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (2.65 KB, patch)
2016-04-14 01:40 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-04-13 09:31:16 PDT 
It shows a nice error page saying there was an error:

SecurityError:​ DOM Exception 18:​ An attempt was made to break through the security policy of the user agent. (at InspectorFrontendHostStub.js:​50:​39)​

It seems WebSockets are blocked.
Comment 1 Carlos Garcia Campos 2016-04-14 01:33:31 PDT 
Adding ws to connect-src fixes this, but then it complains that InspectorFrontendHost.zoomFactor is undefined (this is probably due to r199396)
Comment 2 Carlos Garcia Campos 2016-04-14 01:37:55 PDT 
Created attachment 276379 [details]
Patch
Comment 3 Carlos Garcia Campos 2016-04-14 01:38:57 PDT 
I don't think this is specific to GTK at all.
Comment 4 Carlos Garcia Campos 2016-04-14 01:40:30 PDT 
Created attachment 276380 [details]
Patch
Comment 5 Timothy Hatcher 2016-04-14 09:56:00 PDT 
(In reply to comment #3)
> I don't think this is specific to GTK at all.

It affects anyone using InspectorFrontendHostStub, which we don't use on the Apple ports. This does open web sockets for us, even though the Inspector does not need them on our ports. That is probably fine.
Comment 6 WebKit Commit Bot 2016-04-14 10:44:12 PDT 
Comment on attachment 276380 [details]
Patch

Clearing flags on attachment: 276380

Committed r199541: <http://trac.webkit.org/changeset/199541>
Comment 7 WebKit Commit Bot 2016-04-14 10:44:16 PDT 
All reviewed patches have been landed.  Closing bug.