PrettyPatch crashed when parsing https://bugs.webkit.org/attachment.cgi?id=276320
Created attachment 276328 [details]
This looks like it might be good. Sorry for my unfamiliarity with these tests, but how do I run them?
I've run it with
ruby -IWebsites/bugs.webkit.org/PrettyPatch Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb
4 tests were failing before my patch already
Thanks, this certainly fixes the crash, but does it correctly process the patch?
No. It actually parses '--' in header as a removal mark
Do we have crash report? If this is a crash then is there a Ruby bug for it?
This is not crash in ruby interpreter, only uncaught exception in script
(In reply to comment #7)
> This is not crash in ruby interpreter, only uncaught exception in script
Then "crash" is not correct word to use here. Please update both the bug title of this Bugzilla bug and ChangeLog bug title and description to convey that this fix is for an exception - even better include the name of the exception. If you do not include the name of the exception thrown in the bug title then please explain in English the cause of the exception in the ChangeLog description.
Could you rephrase the changelog and land it?
Actually, I've found that it's not the proper solution to the problem (see comment #5). Script does not bail out anymore, but highlighting can also be fixed.
Have you stumbled upon another "evil" patch? If this is the case I'll reword and submit it ASAP
Nevermind. I only read Comment 8, not Comment 5.