Bug 156521 - CMake MiniBrowser should be an app bundle
Summary: CMake MiniBrowser should be an app bundle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-12 15:12 PDT by Alex Christensen
Modified: 2016-05-23 15:24 PDT (History)
0 users

See Also:


Attachments
Patch (2.68 KB, patch)
2016-04-12 15:13 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2016-04-13 11:37 PDT, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-04-12 15:12:29 PDT
CMake MiniBrowser should be an app bundle
Comment 1 Alex Christensen 2016-04-12 15:13:50 PDT
Created attachment 276284 [details]
Patch
Comment 2 Daniel Bates 2016-04-13 11:11:55 PDT
Comment on attachment 276284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276284&action=review

Can we make use of <https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_BUNDLE.html> or <https://cmake.org/cmake/help/v3.0/module/BundleUtilities.html> instead of building the app bundle by hand?

> Tools/MiniBrowser/mac/CMakeLists.txt:31
> +set(_contents_dir ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/MiniBrowser.app/Contents)

Can we come up with a better name for this variable? Maybe MiniBrowser_Contents_Directory?
Comment 3 Alex Christensen 2016-04-13 11:37:14 PDT
Created attachment 276337 [details]
Patch
Comment 4 Brent Fulgham 2016-04-13 22:09:03 PDT
Comment on attachment 276337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276337&action=review

r=me.

> Tools/ChangeLog:11
> +        CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.

*JUST* MiniBrowser!!! >:-(
Comment 5 Alex Christensen 2016-04-13 22:57:06 PDT
http://trac.webkit.org/changeset/199530
And I snuck in a build fix for JavaScriptCore.