CMake MiniBrowser should be an app bundle
Created attachment 276284 [details] Patch
Comment on attachment 276284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276284&action=review Can we make use of <https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_BUNDLE.html> or <https://cmake.org/cmake/help/v3.0/module/BundleUtilities.html> instead of building the app bundle by hand? > Tools/MiniBrowser/mac/CMakeLists.txt:31 > +set(_contents_dir ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/MiniBrowser.app/Contents) Can we come up with a better name for this variable? Maybe MiniBrowser_Contents_Directory?
Created attachment 276337 [details] Patch
Comment on attachment 276337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276337&action=review r=me. > Tools/ChangeLog:11 > + CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it. This is just MiniBrowser. *JUST* MiniBrowser!!! >:-(
http://trac.webkit.org/changeset/199530 And I snuck in a build fix for JavaScriptCore.