RESOLVED FIXED 156521
CMake MiniBrowser should be an app bundle 
https://bugs.webkit.org/show_bug.cgi?id=156521
Summary CMake MiniBrowser should be an app bundle
Alex Christensen
Reported 2016-04-12 15:12:29 PDT
CMake MiniBrowser should be an app bundle
Attachments
Patch (2.68 KB, patch)
2016-04-12 15:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2016-04-13 11:37 PDT, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-04-12 15:13:50 PDT
Created attachment 276284 [details] Patch
Daniel Bates
Comment 2 2016-04-13 11:11:55 PDT
Comment on attachment 276284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276284&action=review Can we make use of <https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_BUNDLE.html> or <https://cmake.org/cmake/help/v3.0/module/BundleUtilities.html> instead of building the app bundle by hand? > Tools/MiniBrowser/mac/CMakeLists.txt:31 > +set(_contents_dir ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/MiniBrowser.app/Contents) Can we come up with a better name for this variable? Maybe MiniBrowser_Contents_Directory?
Alex Christensen
Comment 3 2016-04-13 11:37:14 PDT
Created attachment 276337 [details] Patch
Brent Fulgham
Comment 4 2016-04-13 22:09:03 PDT
Comment on attachment 276337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276337&action=review r=me. > Tools/ChangeLog:11 > + CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it. This is just MiniBrowser. *JUST* MiniBrowser!!! >:-(
Alex Christensen
Comment 5 2016-04-13 22:57:06 PDT
http://trac.webkit.org/changeset/199530 And I snuck in a build fix for JavaScriptCore.
Note You need to log in before you can comment on or make changes to this bug.