Bug 156516 - AbstractValue should use the result type to filter structures
Summary: AbstractValue should use the result type to filter structures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-12 13:58 PDT by Keith Miller
Modified: 2016-04-12 14:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2016-04-12 14:01 PDT, Keith Miller 		ggaren: review+
ggaren: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-04-12 13:58:33 PDT 
AbstractValue should use the result type to filter structures
Comment 1 Keith Miller 2016-04-12 14:01:24 PDT 
Created attachment 276273 [details]
Patch
Comment 2 Geoffrey Garen 2016-04-12 14:03:35 PDT 
Comment on attachment 276273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276273&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        When filtering filtering an AbstractValue with a SpeculatedType we would not

filtering

> Source/JavaScriptCore/ChangeLog:10
> +        comment directly above said). This would cause us to crash if the our structure

our
Comment 3 Keith Miller 2016-04-12 14:52:02 PDT 
Committed r199391: <http://trac.webkit.org/changeset/199391>