...
Created attachment 276239 [details] patch
Comment on attachment 276239 [details] patch Clearing flags on attachment: 276239 Committed r199376: <http://trac.webkit.org/changeset/199376>
All reviewed patches have been landed. Closing bug.
This caused the Windows Debug builds to fail: <https://build.webkit.org/builders/Apple%20Win%20Debug%20(Build)?numbuilds=50> C:\cygwin\home\buildbot\slave\win-debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4238): error C2039: 'isLocked': is not a member of 'WTF::NoLock' [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock.h(33): note: see declaration of 'WTF::NoLock' C:\cygwin\home\buildbot\slave\win-debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4256): error C2039: 'isLocked': is not a member of 'WTF::NoLock' [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock.h(33): note: see declaration of 'WTF::NoLock' However, I'm not sure why only Windows Debug builds are failing, and not any other platform.
(In reply to comment #4) > This caused the Windows Debug builds to fail: > > <https://build.webkit.org/builders/ > Apple%20Win%20Debug%20(Build)?numbuilds=50> > > C:\cygwin\home\buildbot\slave\win- > debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4238): error C2039: > 'isLocked': is not a member of 'WTF::NoLock' > [C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] > > C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock. > h(33): note: see declaration of 'WTF::NoLock' > C:\cygwin\home\buildbot\slave\win- > debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4256): error C2039: > 'isLocked': is not a member of 'WTF::NoLock' > [C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] > > C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock. > h(33): note: see declaration of 'WTF::NoLock' > > However, I'm not sure why only Windows Debug builds are failing, and not any > other platform. And 32-bit JSC (BuildAndTest) and LLInt CLoop (BuildAndTest) also fail to build due to the same error: <https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50> <https://build.webkit.org/builders/Apple%20El%20Capitan%20LLINT%20CLoop%20(BuildAndTest)?numbuilds=50> <https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50> <https://build.webkit.org/builders/Apple%20Yosemite%20LLINT%20CLoop%20(BuildAndTest)?numbuilds=50> /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:4238:19: error: no member named 'isLocked' in 'WTF::NoLock' /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:4256:19: error: no member named 'isLocked' in 'WTF::NoLock'
Build should be fixed by: http://trac.webkit.org/changeset/199384
<rdar://problem/24718895>