Bug 156495 – Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer

[Darin Adler]

Created attachment 276221 [details]
Patch

[Chris Dumez]

Comment on attachment 276221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review

> Source/WebCore/dom/DataTransfer.idl:41
> +    void setDragImage(Element? image, long x, long y);

Hmm, this does not match the spec:
https://html.spec.whatwg.org/multipage/interaction.html#datatransfer

[Darin Adler]

Comment on attachment 276221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review

>> Source/WebCore/dom/DataTransfer.idl:41
>> +    void setDragImage(Element? image, long x, long y);
> 
> Hmm, this does not match the spec:
> https://html.spec.whatwg.org/multipage/interaction.html#datatransfer

Our behavior of accepting null to mean we should remove/clear the drag image predates the spec by many years. It’s OK to change to match the specification, but we’d want to add regression tests and consider the backwards compatibility costs of making the change.

[Darin Adler]

Maybe we should add a FIXME comment about matching the specification in the future?

[Chris Dumez]

(In reply to comment #4)
> Maybe we should add a FIXME comment about matching the specification in the
> future?

Sound good to me.

[Darin Adler]

Created attachment 276326 [details]
Patch

[Chris Dumez]

Comment on attachment 276326 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 276326 [details]
Patch

Clearing flags on attachment: 276326

Committed r199500: <http://trac.webkit.org/changeset/199500>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.