Bug 156495 - Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer
Summary: Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-11 22:23 PDT by Darin Adler
Modified: 2016-04-13 10:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2016-04-11 22:24 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2016-04-13 09:12 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-04-11 22:23:49 PDT 
Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer
Comment 1 Darin Adler 2016-04-11 22:24:25 PDT 
Created attachment 276221 [details]
Patch
Comment 2 Chris Dumez 2016-04-12 08:27:58 PDT 
Comment on attachment 276221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review

> Source/WebCore/dom/DataTransfer.idl:41
> +    void setDragImage(Element? image, long x, long y);

Hmm, this does not match the spec:
https://html.spec.whatwg.org/multipage/interaction.html#datatransfer
Comment 3 Darin Adler 2016-04-12 09:20:39 PDT 
Comment on attachment 276221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review

>> Source/WebCore/dom/DataTransfer.idl:41
>> +    void setDragImage(Element? image, long x, long y);
> 
> Hmm, this does not match the spec:
> https://html.spec.whatwg.org/multipage/interaction.html#datatransfer

Our behavior of accepting null to mean we should remove/clear the drag image predates the spec by many years. It’s OK to change to match the specification, but we’d want to add regression tests and consider the backwards compatibility costs of making the change.
Comment 4 Darin Adler 2016-04-12 09:20:59 PDT 
Maybe we should add a FIXME comment about matching the specification in the future?
Comment 5 Chris Dumez 2016-04-12 09:24:42 PDT 
(In reply to comment #4)
> Maybe we should add a FIXME comment about matching the specification in the
> future?

Sound good to me.
Comment 6 Darin Adler 2016-04-13 09:12:15 PDT 
Created attachment 276326 [details]
Patch
Comment 7 Chris Dumez 2016-04-13 09:21:24 PDT 
Comment on attachment 276326 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2016-04-13 10:13:05 PDT 
Comment on attachment 276326 [details]
Patch

Clearing flags on attachment: 276326

Committed r199500: <http://trac.webkit.org/changeset/199500>
Comment 9 WebKit Commit Bot 2016-04-13 10:13:09 PDT 
All reviewed patches have been landed.  Closing bug.