Bug 156491 - Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
Summary: Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-11 21:20 PDT by Darin Adler
Modified: 2016-04-11 22:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.18 KB, patch)
2016-04-11 21:22 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-04-11 21:20:32 PDT 
Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
Comment 1 Darin Adler 2016-04-11 21:22:46 PDT 
Created attachment 276214 [details]
Patch
Comment 2 Chris Dumez 2016-04-11 21:40:56 PDT 
Comment on attachment 276214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276214&action=review

r=me

> Source/WebCore/html/HTMLOptionsCollection.h:42
> +    HTMLOptionElement* item(unsigned offset) const final;

is this the pattern now?
final seems redundant since the class already is final.
Comment 3 Darin Adler 2016-04-11 21:57:19 PDT 
(In reply to comment #2)
> > Source/WebCore/html/HTMLOptionsCollection.h:42
> > +    HTMLOptionElement* item(unsigned offset) const final;
> 
> is this the pattern now?
> final seems redundant since the class already is final.

This was discussed on webkit-dev:

https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html
https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html
https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html
https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html
https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html

That lats message is where the discussion ended. If you like we can debate it again.
Comment 4 Chris Dumez 2016-04-11 22:04:11 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > > Source/WebCore/html/HTMLOptionsCollection.h:42
> > > +    HTMLOptionElement* item(unsigned offset) const final;
> > 
> > is this the pattern now?
> > final seems redundant since the class already is final.
> 
> This was discussed on webkit-dev:
> 
> https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html
> https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html
> https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html
> https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html
> https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html
> 
> That lats message is where the discussion ended. If you like we can debate
> it again.

I don't really mind it, I was merely curious.
Comment 5 WebKit Commit Bot 2016-04-11 22:49:41 PDT 
Comment on attachment 276214 [details]
Patch

Clearing flags on attachment: 276214

Committed r199335: <http://trac.webkit.org/changeset/199335>
Comment 6 WebKit Commit Bot 2016-04-11 22:49:47 PDT 
All reviewed patches have been landed.  Closing bug.