RESOLVED FIXED 156491
Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection 
https://bugs.webkit.org/show_bug.cgi?id=156491
Summary Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
Darin Adler
Reported 2016-04-11 21:20:32 PDT
Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
Attachments
Patch (4.18 KB, patch)
2016-04-11 21:22 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-04-11 21:22:46 PDT
Created attachment 276214 [details] Patch
Chris Dumez
Comment 2 2016-04-11 21:40:56 PDT
Comment on attachment 276214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276214&action=review r=me > Source/WebCore/html/HTMLOptionsCollection.h:42 > + HTMLOptionElement* item(unsigned offset) const final; is this the pattern now? final seems redundant since the class already is final.
Darin Adler
Comment 3 2016-04-11 21:57:19 PDT
(In reply to comment #2) > > Source/WebCore/html/HTMLOptionsCollection.h:42 > > + HTMLOptionElement* item(unsigned offset) const final; > > is this the pattern now? > final seems redundant since the class already is final. This was discussed on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html That lats message is where the discussion ended. If you like we can debate it again.
Chris Dumez
Comment 4 2016-04-11 22:04:11 PDT
(In reply to comment #3) > (In reply to comment #2) > > > Source/WebCore/html/HTMLOptionsCollection.h:42 > > > + HTMLOptionElement* item(unsigned offset) const final; > > > > is this the pattern now? > > final seems redundant since the class already is final. > > This was discussed on webkit-dev: > > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html > > That lats message is where the discussion ended. If you like we can debate > it again. I don't really mind it, I was merely curious.
WebKit Commit Bot
Comment 5 2016-04-11 22:49:41 PDT
Comment on attachment 276214 [details] Patch Clearing flags on attachment: 276214 Committed r199335: <http://trac.webkit.org/changeset/199335>
WebKit Commit Bot
Comment 6 2016-04-11 22:49:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.