Bug 156475 - Web Inspector: Unstyled nodes in ObjectTree previews look poor
Summary: Web Inspector: Unstyled nodes in ObjectTree previews look poor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-11 15:24 PDT by Joseph Pecoraro
Modified: 2016-04-11 16:47 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.26 KB, patch)
2016-04-11 15:40 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Before (49.23 KB, image/png)
2016-04-11 15:41 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After (46.24 KB, image/png)
2016-04-11 15:41 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-11 15:24:49 PDT 
* SUMMARY
Unstyled nodes in ObjectTree previews look poor.

Previously <div class="foo"> would have been "div.foo { ... }". For heap allocations I changed the description of nodes to just send <div class="foo"> and we would highlight it. Do the same for ObjectPreviews and avoid cluttering the UI with {...} properties.
Comment 1 Radar WebKit Bug Importer 2016-04-11 15:25:21 PDT 
<rdar://problem/25667351>
Comment 2 Joseph Pecoraro 2016-04-11 15:40:53 PDT 
Created attachment 276176 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-04-11 15:41:07 PDT 
Created attachment 276177 [details]
[IMAGE] Before
Comment 4 Joseph Pecoraro 2016-04-11 15:41:18 PDT 
Created attachment 276178 [details]
[IMAGE] After
Comment 5 WebKit Commit Bot 2016-04-11 16:47:08 PDT 
Comment on attachment 276176 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 276176

Committed r199322: <http://trac.webkit.org/changeset/199322>
Comment 6 WebKit Commit Bot 2016-04-11 16:47:12 PDT 
All reviewed patches have been landed.  Closing bug.