WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156474
Lazily update tokens in DOMTokenList when the associated attribute value changes
https://bugs.webkit.org/show_bug.cgi?id=156474
Summary
Lazily update tokens in DOMTokenList when the associated attribute value changes
Chris Dumez
Reported
2016-04-11 15:03:01 PDT
Lazily update tokens in DOMTokenList when the associated attribute value changes for performance.
Attachments
Patch
(13.81 KB, patch)
2016-04-11 15:06 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(13.89 KB, patch)
2016-04-12 08:30 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-04-11 15:06:44 PDT
Created
attachment 276175
[details]
Patch
Ryosuke Niwa
Comment 2
2016-04-11 16:32:57 PDT
Comment on
attachment 276175
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=276175&action=review
> Source/WebCore/html/DOMTokenList.cpp:231 > + updateTokensFromAttributeValue(m_element.getAttribute(m_attributeName));
Use fastGetAttribute?
Chris Dumez
Comment 3
2016-04-12 08:30:27 PDT
Created
attachment 276236
[details]
Patch
WebKit Commit Bot
Comment 4
2016-04-12 09:21:43 PDT
Comment on
attachment 276236
[details]
Patch Clearing flags on attachment: 276236 Committed
r199360
: <
http://trac.webkit.org/changeset/199360
>
WebKit Commit Bot
Comment 5
2016-04-12 09:21:47 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6
2016-04-12 11:35:32 PDT
Re-opened since this is blocked by
bug 156508
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug