Bug 156474 - Lazily update tokens in DOMTokenList when the associated attribute value changes
Summary: Lazily update tokens in DOMTokenList when the associated attribute value changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 156508 156509
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-11 15:03 PDT by Chris Dumez
Modified: 2016-04-13 14:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.81 KB, patch)
2016-04-11 15:06 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (13.89 KB, patch)
2016-04-12 08:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-11 15:03:01 PDT
Lazily update tokens in DOMTokenList when the associated attribute value changes for performance.
Comment 1 Chris Dumez 2016-04-11 15:06:44 PDT
Created attachment 276175 [details]
Patch
Comment 2 Ryosuke Niwa 2016-04-11 16:32:57 PDT
Comment on attachment 276175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276175&action=review

> Source/WebCore/html/DOMTokenList.cpp:231
> +        updateTokensFromAttributeValue(m_element.getAttribute(m_attributeName));

Use fastGetAttribute?
Comment 3 Chris Dumez 2016-04-12 08:30:27 PDT
Created attachment 276236 [details]
Patch
Comment 4 WebKit Commit Bot 2016-04-12 09:21:43 PDT
Comment on attachment 276236 [details]
Patch

Clearing flags on attachment: 276236

Committed r199360: <http://trac.webkit.org/changeset/199360>
Comment 5 WebKit Commit Bot 2016-04-12 09:21:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2016-04-12 11:35:32 PDT
Re-opened since this is blocked by bug 156508