Bug 156473 - Rename WKOpenPanelParameters files to WKOpenPanelParametersRef
Summary: Rename WKOpenPanelParameters files to WKOpenPanelParametersRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-11 12:55 PDT by Anders Carlsson
Modified: 2016-04-11 14:32 PDT (History)
0 users

See Also:

Attachments
Patch (20.37 KB, patch)
2016-04-11 12:56 PDT, Anders Carlsson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-04-11 12:55:46 PDT 
Rename WKOpenPanelParameters files to WKOpenPanelParametersRef
Comment 1 Anders Carlsson 2016-04-11 12:56:50 PDT 
Created attachment 276167 [details]
Patch
Comment 2 Alex Christensen 2016-04-11 13:18:01 PDT 
Comment on attachment 276167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276167&action=review

r=me, please update CMakeLists.txt

> Source/WebKit2/UIProcess/API/C/WKOpenPanelParametersRef.cpp:54
> +    return 0;

nullptr?
Comment 3 Anders Carlsson 2016-04-11 13:27:35 PDT 
This won't work, going to think of something different.
Comment 4 Anders Carlsson 2016-04-11 14:02:39 PDT 
Actually, we can use this!
Comment 5 Anders Carlsson 2016-04-11 14:32:29 PDT 
Committed r199311: <http://trac.webkit.org/changeset/199311>