Bug 156468 – Merge AttributedDOMTokenList into DOMTokenList

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Merge AttributedDOMTokenList into AttributeTokenList to simplify the code. DOMTokenList is not constructible and AttributedDOMTokenList is its only constructible subclass.

[Chris Dumez]

Created attachment 276157 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 276157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276157&action=review

> Source/WebCore/html/DOMTokenList.cpp:203
> +    // Do not reset the DOMTokenList value if the attribute value was changed by us.

Why don't we assert that m_element is non-null.

> Source/WebCore/html/DOMTokenList.cpp:212
> +    m_cachedValue = nullAtom;

Ditto.

[Chris Dumez]

Comment on attachment 276157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276157&action=review

>> Source/WebCore/html/DOMTokenList.cpp:203
>> +    // Do not reset the DOMTokenList value if the attribute value was changed by us.
> 
> Why don't we assert that m_element is non-null.

because m_element is a reference?

[Ryosuke Niwa]

Sorry, I meant to say attributeName.

[Chris Dumez]

(In reply to comment #4)
> Sorry, I meant to say attributeName.

attributeName is passed to the constructor and is a QualifiedName, stored as m_attributeName.

[Ryosuke Niwa]

Oh sorry, I misread your patch. I thought we had two constructors but we don't.

[Chris Dumez]

Comment on attachment 276157 [details]
Patch

Clearing flags on attachment: 276157

Committed r199298: <http://trac.webkit.org/changeset/199298>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.