The FOLDER property is set to some CMake targets to structure the generated Visual Studio solutions. (Bug 83571) But, some targets are not set the FOLDER property and generated project are in top folder in the solution. Making FOLDER property INHERITED is the easy way to set the proeprty to all targets under a directory. https://cmake.org/cmake/help/latest/command/define_property.html
Created attachment 276120 [details] Patch
Created attachment 276121 [details] screen shot of before
Created attachment 276122 [details] screen shot of after
Comment on attachment 276120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276120&action=review Thank you for this fix! I found a couple of minor errors in the ChangeLog. If you fix them, we can land the change. > ChangeLog:8 > + Some CMake targets are not set the FOLDER property and Some CMake targets are not setting the FOLDER property. This causes the > ChangeLog:9 > + generated projects are in the top folder in the solution. generated projects to be displayed in the top-level folder of the solution. > ChangeLog:11 > + Making FOLDER property INHERITED is the easy way to set the Making the FOLDER property INHERITED ensures that all the targets > ChangeLog:12 > + proeprty to all targets under a directory. are placed in their proper directories.
Created attachment 276129 [details] Patch Thank you for reviewing my patch.
Comment on attachment 276129 [details] Patch Thank you so much for this patch! r=me.
Comment on attachment 276129 [details] Patch Clearing flags on attachment: 276129 Committed r199289: <http://trac.webkit.org/changeset/199289>
All reviewed patches have been landed. Closing bug.