Bug 156453 - DOMTokenList.contains() should not throw
Summary: DOMTokenList.contains() should not throw
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/whatwg/dom/commit/...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-04-10 13:44 PDT by Chris Dumez
Modified: 2016-05-10 23:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (24.51 KB, patch)
2016-04-10 14:12 PDT, Chris Dumez 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-10 13:44:00 PDT 
DOMTokenList.contains() should not throw if the input token is invalid:
https://github.com/whatwg/dom/commit/6d3076e3cbcba662489b272a718bc6b8c0082a74
Comment 1 Chris Dumez 2016-04-10 14:07:12 PDT 
First updating web-platform-tests via:
https://github.com/w3c/web-platform-tests/pull/2809
Comment 2 Chris Dumez 2016-04-10 14:12:50 PDT 
Created attachment 276107 [details]
Patch
Comment 3 Ryosuke Niwa 2016-04-11 09:46:52 PDT 
Comment on attachment 276107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276107&action=review

> LayoutTests/imported/w3c/ChangeLog:8
> +        Re-sync dom/nodes/Element-classlist.html with upstream.

Could you add the git hash to which you're synced?
Comment 4 Chris Dumez 2016-04-11 09:50:39 PDT 
Committed r199296: <http://trac.webkit.org/changeset/199296>