Bug 156449 - Update Animometer to accommodate different screens
Summary: Update Animometer to accommodate different screens
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-09 20:15 PDT by Jon Lee
Modified: 2016-04-11 19:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.56 KB, patch)
2016-04-09 22:55 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (10.61 KB, patch)
2016-04-11 19:11 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2016-04-09 20:15:41 PDT 
Update Animometer to accommodate different screens
Comment 1 Jon Lee 2016-04-09 22:55:04 PDT 
Created attachment 276100 [details]
Patch
Comment 2 Said Abou-Hallawa 2016-04-11 17:40:49 PDT 
Comment on attachment 276100 [details]
Patch

Looks good to me.  But I think the @media css rules deserve inline comments since it is hard to know exactly what devices these rules are targeting without reading the ChangeLog or searching the internet.
Comment 3 Jon Lee 2016-04-11 19:11:15 PDT 
Created attachment 276198 [details]
Patch
Comment 4 Jon Lee 2016-04-11 19:12:08 PDT 
Whoops. Meant to land, not post another patch.
Comment 5 Jon Lee 2016-04-11 19:13:14 PDT 
Committed r199328: <http://trac.webkit.org/changeset/199328>