Bug 156429 – [iOS WK2] WKWebViews should consult ancestor UIScrollViews to determine tiling area

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

[iOS WK2] WKWebViews should consult ancestor UIScrollViews to determine tiling area

[Simon Fraser (smfr)]

Created attachment 276062 [details]
Patch

[Simon Fraser (smfr)]

rdar://problem/25455111

[WebKit Commit Bot]

Attachment 276062 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:60:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 276062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276062&action=review

> Source/WebCore/page/Page.h:302
> +    bool enclosedInScrollView() const { return m_enclosedInScrollView; }
> +    void setEnclosedInScrollView(bool f) { m_enclosedInScrollView = f; }

I wonder if this is too generic. We have something called ScrollView, which this has nothing to do with.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1870
> +    if (_enclosingScrollViewScrollTimer)

Why NSTimer instead of a DeferrableOneShot? That will be a lot cheaper than rescheduling an NSTimer every scrolling increment.

[Simon Fraser (smfr)]

https://trac.webkit.org/r199259

[Chris Dumez]

Reverted r199259 and r200161 for reason:

Seems to have caused a ~1.2% PLT regression on iOS

Committed r200390: <http://trac.webkit.org/changeset/200390>

[Simon Fraser (smfr)]

It was re-landed in https://trac.webkit.org/r200470