Bug 156429 - [iOS WK2] WKWebViews should consult ancestor UIScrollViews to determine tiling area
Summary: [iOS WK2] WKWebViews should consult ancestor UIScrollViews to determine tilin...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2016-04-08 17:11 PDT by Simon Fraser (smfr)
Modified: 2016-05-09 12:32 PDT (History)
6 users (show)

See Also:

Patch (32.89 KB, patch)
2016-04-08 17:23 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-04-08 17:11:28 PDT
[iOS WK2] WKWebViews should consult ancestor UIScrollViews to determine tiling area
Comment 1 Simon Fraser (smfr) 2016-04-08 17:23:21 PDT
Created attachment 276062 [details]
Comment 2 Simon Fraser (smfr) 2016-04-08 17:23:52 PDT
Comment 3 WebKit Commit Bot 2016-04-08 17:25:11 PDT
Attachment 276062 [details] did not pass style-queue:

ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:60:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 15 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2016-04-08 17:27:40 PDT
Comment on attachment 276062 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=276062&action=review

> Source/WebCore/page/Page.h:302
> +    bool enclosedInScrollView() const { return m_enclosedInScrollView; }
> +    void setEnclosedInScrollView(bool f) { m_enclosedInScrollView = f; }

I wonder if this is too generic. We have something called ScrollView, which this has nothing to do with.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1870
> +    if (_enclosingScrollViewScrollTimer)

Why NSTimer instead of a DeferrableOneShot? That will be a lot cheaper than rescheduling an NSTimer every scrolling increment.
Comment 5 Simon Fraser (smfr) 2016-04-08 18:19:13 PDT
Comment 6 Chris Dumez 2016-05-03 15:19:32 PDT
Reverted r199259 and r200161 for reason:

Seems to have caused a ~1.2% PLT regression on iOS

Committed r200390: <http://trac.webkit.org/changeset/200390>
Comment 7 Simon Fraser (smfr) 2016-05-09 12:32:17 PDT
It was re-landed in https://trac.webkit.org/r200470