Bug 156427 - Escape builder names in url* and pathFor* methods of BuildbotSyncer
Summary: Escape builder names in url* and pathFor* methods of BuildbotSyncer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-08 16:41 PDT by Ryosuke Niwa
Modified: 2016-04-08 21:56 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (29.75 KB, patch)
2016-04-08 16:46 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed one more bug (34.71 KB, patch)
2016-04-08 20:02 PDT, Ryosuke Niwa 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-04-08 16:41:18 PDT 
Turns out that my build fix in http://trac.webkit.org/changeset/199251 breaks other usage of RemoteAPI.
Fix it properly by escaping builder names in BuildbotSyncer's methods.
Comment 1 Ryosuke Niwa 2016-04-08 16:46:59 PDT 
Created attachment 276053 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2016-04-08 20:02:26 PDT 
Created attachment 276075 [details]
Fixed one more bug
Comment 3 Ryosuke Niwa 2016-04-08 21:55:46 PDT 
Thanks for the reviews!
Comment 4 Ryosuke Niwa 2016-04-08 21:56:38 PDT 
Committed r199266: <http://trac.webkit.org/changeset/199266>