Bug 156424 - Web Inspector: primitive InspectorValue casts should use Optional<T> and templates
Summary: Web Inspector: primitive InspectorValue casts should use Optional<T> and temp...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on: 156407
Blocks: InspectorProtocol
  Show dependency tree / graph
 
Reported: 2016-04-08 16:20 PDT by BJ Burg
Modified: 2016-12-13 15:39 PST (History)
10 users (show)

See Also:

Attachments
Proposed Fix (38.25 KB, patch)
2016-04-08 16:51 PDT, BJ Burg 		bburg: review-
bburg: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (878.09 KB, application/zip)
2016-04-08 17:23 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (962.72 KB, application/zip)
2016-04-08 17:28 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (911.63 KB, application/zip)
2016-04-08 17:32 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-04-08 16:20:13 PDT 
.
Comment 1 Radar WebKit Bug Importer 2016-04-08 16:21:13 PDT 
<rdar://problem/25636479>
Comment 2 BJ Burg 2016-04-08 16:51:36 PDT 
Created attachment 276054 [details]
Proposed Fix
Comment 3 BJ Burg 2016-04-08 16:52:12 PDT 
Comment on attachment 276054 [details]
Proposed Fix

Needs to land with corresponding internal change.
Comment 4 WebKit Commit Bot 2016-04-08 16:52:32 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 5 Build Bot 2016-04-08 17:23:23 PDT 
Comment on attachment 276054 [details]
Proposed Fix

Attachment 276054 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1122964

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-04-08 17:23:26 PDT 
Created attachment 276063 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-04-08 17:28:21 PDT 
Comment on attachment 276054 [details]
Proposed Fix

Attachment 276054 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1123000

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-04-08 17:28:24 PDT 
Created attachment 276064 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-04-08 17:32:46 PDT 
Comment on attachment 276054 [details]
Proposed Fix

Attachment 276054 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1123003

Number of test failures exceeded the failure limit.
Comment 10 Build Bot 2016-04-08 17:32:49 PDT 
Created attachment 276065 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 BJ Burg 2016-04-11 11:23:18 PDT 
Comment on attachment 276054 [details]
Proposed Fix

Clearing r? since dependent bug was rolled out.