Bug 156396 - Remove unneeded UsePointersEvenForNonNullableObjectArguments from event classes
Summary: Remove unneeded UsePointersEvenForNonNullableObjectArguments from event classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-08 00:53 PDT by Darin Adler
Modified: 2019-02-06 09:03 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.06 KB, patch)
2016-04-08 00:53 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-04-08 00:53:13 PDT
Remove unneeded UsePointersEvenForNonNullableObjectArguments from event classes
Comment 1 Darin Adler 2016-04-08 00:53:40 PDT
Created attachment 275983 [details]
Patch
Comment 2 Darin Adler 2016-04-08 01:10:28 PDT
If these were needed, then removing them without changing the C++ DOM code would cause a build failure. Successful builds will demonstrate the keywords were not needed.
Comment 3 youenn fablet 2016-04-08 01:14:24 PDT
r=me.
Thanks for cleaning this.

(In reply to comment #2)
> If these were needed, then removing them without changing the C++ DOM code
> would cause a build failure. Successful builds will demonstrate the keywords
> were not needed.

Yes, the binding generator is handling the case of these parameters (not marked as nullable, but optional with undefined as default).
Comment 4 WebKit Commit Bot 2016-04-08 02:04:17 PDT
Comment on attachment 275983 [details]
Patch

Clearing flags on attachment: 275983

Committed r199224: <http://trac.webkit.org/changeset/199224>
Comment 5 WebKit Commit Bot 2016-04-08 02:04:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Lucas Forschler 2019-02-06 09:03:28 PST
Mass moving XML DOM bugs to the "DOM" Component.