WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156392
[iOS WK2] Stop using exposedContentRect for history scroll state restoration
https://bugs.webkit.org/show_bug.cgi?id=156392
Summary
[iOS WK2] Stop using exposedContentRect for history scroll state restoration
Simon Fraser (smfr)
Reported
2016-04-07 21:12:12 PDT
[iOS WK2] Stop using exposedContentRect for history scroll state restoration
Attachments
Patch
(35.55 KB, patch)
2016-04-07 21:18 PDT
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2016-04-07 21:18:25 PDT
Created
attachment 275978
[details]
Patch
WebKit Commit Bot
Comment 2
2016-04-07 21:20:09 PDT
Attachment 275978
[details]
did not pass style-queue: ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2016-04-08 10:03:46 PDT
Comment on
attachment 275978
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=275978&action=review
> Source/WebCore/history/HistoryItem.h:271 > + FloatSize m_obscuredInset;
It seems somewhat weird that you are only saving 1/2 of the values of the obscured inset. I realize those are the ones you need, but it still seems weird.
Simon Fraser (smfr)
Comment 4
2016-04-08 10:22:57 PDT
https://trac.webkit.org/r199233
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug