Bug 156392 - [iOS WK2] Stop using exposedContentRect for history scroll state restoration
Summary: [iOS WK2] Stop using exposedContentRect for history scroll state restoration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-07 21:12 PDT by Simon Fraser (smfr)
Modified: 2016-04-08 10:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (35.55 KB, patch)
2016-04-07 21:18 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-04-07 21:12:12 PDT 
[iOS WK2] Stop using exposedContentRect for history scroll state restoration
Comment 1 Simon Fraser (smfr) 2016-04-07 21:18:25 PDT 
Created attachment 275978 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-07 21:20:09 PDT 
Attachment 275978 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:50:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2016-04-08 10:03:46 PDT 
Comment on attachment 275978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275978&action=review

> Source/WebCore/history/HistoryItem.h:271
> +    FloatSize m_obscuredInset;

It seems somewhat weird that  you are only saving 1/2 of the values of the obscured inset. I realize those are the ones you need, but it still seems weird.
Comment 4 Simon Fraser (smfr) 2016-04-08 10:22:57 PDT 
https://trac.webkit.org/r199233