RESOLVED FIXED 156385
Web Inspector: Attempting to dismiss a popover that is already being dismissed causes an error 
https://bugs.webkit.org/show_bug.cgi?id=156385
Summary Web Inspector: Attempting to dismiss a popover that is already being dismisse...
Matt Baker
Reported 2016-04-07 20:23:12 PDT
* SUMMARY Attempting to dismiss a popover that is already being dismissed causes an error. * STEPS TO REPRODUCE 1. Set breakpoint, open Edit Breakpoint popover 2. Condition field has the focus. Hit Enter twice in quick succession. => BreakpointPopoverController.js:249:22: CONSOLE ERROR TypeError: null is not an object (evaluating 'this._popover.dismiss') 1. Debugger tab > Scope Chain sidebar panel > Add Watch Expression 2. Condition field has the focus. Hit Enter twice in quick succession. => ScopeChainDetailsSidebarPanel.js:453:46: CONSOLE ERROR TypeError: null is not an object (evaluating 'this._codeMirror.getValue')
Attachments
[Patch] Proposed Fix (4.75 KB, patch)
2016-04-07 20:34 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (3.74 KB, patch)
2016-04-08 01:50 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-07 20:23:26 PDT
<rdar://problem/25617962>
Matt Baker
Comment 2 2016-04-07 20:34:04 PDT
Created attachment 275973 [details] [Patch] Proposed Fix
Blaze Burg
Comment 3 2016-04-07 20:42:14 PDT
Comment on attachment 275973 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=275973&action=review Is the dismissing flag ever cleared when the animation completes? Or do you rely on later present() calls to reset it? It seems weird to have the dismissing flag always true even once it's out of the DOM. > Source/WebInspectorUI/ChangeLog:24 > +2016-04-07 Matt Baker <mattbaker@apple.com> You made a double changelog.
Matt Baker
Comment 4 2016-04-08 01:50:46 PDT
Created attachment 275984 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2016-04-08 09:05:20 PDT
Comment on attachment 275984 [details] [Patch] Proposed Fix Clearing flags on attachment: 275984 Committed r199227: <http://trac.webkit.org/changeset/199227>
WebKit Commit Bot
Comment 6 2016-04-08 09:05:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.