Bug 156384 – Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Joseph Pecoraro]

Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards.

All tests pass. We've had the feature enabled by default for over a year. Multiple WebKit browser releases have included the feature enabled.

Should we also update the features.json status to "Done", or are there parts (native subclassing) that are still considered "In Development"?

[Joseph Pecoraro]

Created attachment 275969 [details]
[PATCH] Proposed Fix - Unskip

[WebKit Commit Bot]

Attachment 275969 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Created attachment 275970 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 275970 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275970&action=review

> Source/JavaScriptCore/ChangeLog:4
> +        Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
> +        https://bugs.webkit.org/show_bug.cgi?id=156384

Thoughts on marking the feature "Done" in JavaScriptCore/features.json?

[WebKit Commit Bot]

Attachment 275970 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Comment on attachment 275970 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275970&action=review

>> Source/JavaScriptCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=156384
> 
> Thoughts on marking the feature "Done" in JavaScriptCore/features.json?

I think we can make it as done now.

[Joseph Pecoraro]

Created attachment 275971 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Attachment 275971 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

> >> Source/JavaScriptCore/ChangeLog:4
> >> +        https://bugs.webkit.org/show_bug.cgi?id=156384
> > 
> > Thoughts on marking the feature "Done" in JavaScriptCore/features.json?
> 
> I think we can make it as done now.

If there is anything wrong with our class implementation it's a bug and not a lack of feature work.

[WebKit Commit Bot]

Comment on attachment 275971 [details]
[PATCH] For Landing

Clearing flags on attachment: 275971

Committed r199214: <http://trac.webkit.org/changeset/199214>