Bug 156376 - [css-grid] Remove unnecessary iteration in populateGridPositions loop
Summary: [css-grid] Remove unnecessary iteration in populateGridPositions loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-07 16:31 PDT by Javier Fernandez
Modified: 2016-04-08 01:01 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.32 KB, patch)
2016-04-07 16:36 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2016-04-07 16:31:26 PDT
The loop implemented in the populateGridPositions has an incorrect limit and the last operation is overwritten in the next line of code after the loop. Even that it does o cause a bug, it makes no sense and needs to be changed.
Comment 1 Javier Fernandez 2016-04-07 16:36:47 PDT
Created attachment 275955 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-08 01:01:05 PDT
Comment on attachment 275955 [details]
Patch

Clearing flags on attachment: 275955

Committed r199222: <http://trac.webkit.org/changeset/199222>
Comment 3 WebKit Commit Bot 2016-04-08 01:01:09 PDT
All reviewed patches have been landed.  Closing bug.