Bug 156372 - [OS X] Flakey crash after ScrollAnimatorMac destruction
Summary: [OS X] Flakey crash after ScrollAnimatorMac destruction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 156225
  Show dependency tree / graph
 
Reported: 2016-04-07 15:26 PDT by Myles C. Maxfield
Modified: 2016-04-12 11:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.56 KB, patch)
2016-04-07 15:41 PDT, Myles C. Maxfield 		mmaxfield: review-
Details | Formatted Diff | Diff
WIP (4.52 KB, patch)
2016-04-07 15:47 PDT, Myles C. Maxfield 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (849.56 KB, application/zip)
2016-04-07 16:31 PDT, Build Bot 		no flags Details
WIP (10.85 KB, patch)
2016-04-11 20:51 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (13.77 KB, patch)
2016-04-11 21:57 PDT, Myles C. Maxfield 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (641.11 KB, application/zip)
2016-04-11 22:49 PDT, Build Bot 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-04-07 15:26:21 PDT 
[OS X] Flakey crash after ScrollAnimatorMac destruction
Comment 1 Myles C. Maxfield 2016-04-07 15:41:24 PDT 
Created attachment 275948 [details]
Patch
Comment 2 Myles C. Maxfield 2016-04-07 15:46:29 PDT 
Comment on attachment 275948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275948&action=review

> Source/WebCore/ChangeLog:24
> +        does not.

This is false. The only subclass of ScrollView (namely, FrameView) already does this. Because ScrollView is abstract, this deregistration must already occur.
Comment 3 Myles C. Maxfield 2016-04-07 15:47:11 PDT 
Created attachment 275949 [details]
WIP
Comment 4 Build Bot 2016-04-07 16:31:49 PDT 
Comment on attachment 275949 [details]
WIP

Attachment 275949 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1117244

New failing tests:
fast/scrolling/scrollbar-mousedown-mouseup.html
Comment 5 Build Bot 2016-04-07 16:31:52 PDT 
Created attachment 275954 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Myles C. Maxfield 2016-04-11 20:51:53 PDT 
Created attachment 276207 [details]
WIP
Comment 7 Myles C. Maxfield 2016-04-11 21:57:59 PDT 
Created attachment 276217 [details]
Patch
Comment 8 Darin Adler 2016-04-11 22:03:18 PDT 
Comment on attachment 276217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276217&action=review

> Source/WebCore/page/Settings.cpp:632
> +// It's very important that this setting doesn't change in the middle of a document's lifetime.
> +// The Mac port uses this flag when registering and deregistering platform-dependent scrollbar
> +// objects. Therefore, if this changes at an unexpected time, deregistration may not happen
> +// correctly, which may cause the platform to follow dangling pointers.

This doesn’t sound good! Seems bad to have the code be fragile in this manner. Might be fixable.
Comment 9 Build Bot 2016-04-11 22:49:43 PDT 
Comment on attachment 276217 [details]
Patch

Attachment 276217 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1140009

New failing tests:
fast/scrolling/rtl-scrollbars-animation-property.html
Comment 10 Build Bot 2016-04-11 22:49:47 PDT 
Created attachment 276223 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5
Comment 11 Myles C. Maxfield 2016-04-12 11:33:52 PDT 
Committed r199375: <http://trac.webkit.org/changeset/199375>