Bug 156371 – Web Inspector: ProfileView source links are off by 1 line, worse in pretty printed code

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
ProfileView source links are off by 1 line, worse in pretty printed code.

* TEST
<script>
function runFor(ms) {
    var until = Date.now() + ms;
    while (Date.now() < until);
}

function doWork() {
    runFor(200);
}

setTimeout(() => { doWork() }, 0);
</script>

* STEPS TO REPRODUCE
1. Inspect test page
2. Timeline record it doing work
3. Show Profile View
4. Jump to "runFor"
  => off by 1, it highlights the line with `until` and not `runFor`

* NOTES
- Protocol produces 1-based line numbers, but SourceCodeLocation expects 0-based.

[Radar WebKit Bug Importer]

<rdar://problem/25612513>

[Joseph Pecoraro]

Created attachment 275946 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 275946 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275946

Committed r199201: <http://trac.webkit.org/changeset/199201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.