RESOLVED FIXED 156352
Rationalize the makeSpaceForCCall stuff 
https://bugs.webkit.org/show_bug.cgi?id=156352
Summary Rationalize the makeSpaceForCCall stuff
Filip Pizlo
Reported 2016-04-07 11:19:39 PDT
Patch forthcoming.
Attachments
the patch (7.97 KB, patch)
2016-04-07 11:24 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-04-07 11:24:38 PDT
Created attachment 275901 [details] the patch
Mark Lam
Comment 2 2016-04-07 11:29:28 PDT
Comment on attachment 275901 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=275901&action=review r=me > Source/JavaScriptCore/ChangeLog:18 > + the old value of scratchGPR, but the condition woudln't necessarily trigger. So if the call typo: /woudln't/wouldn't/ > Source/JavaScriptCore/ChangeLog:21 > + Making room on the stack for a call is cheap operation. It's orders of magnitude cheaper Missing "a" between "is cheap".
Filip Pizlo
Comment 3 2016-04-07 11:36:39 PDT
(In reply to comment #2) > Comment on attachment 275901 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=275901&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:18 > > + the old value of scratchGPR, but the condition woudln't necessarily trigger. So if the call > > typo: /woudln't/wouldn't/ > > > Source/JavaScriptCore/ChangeLog:21 > > + Making room on the stack for a call is cheap operation. It's orders of magnitude cheaper > > Missing "a" between "is cheap". Thanks!
Filip Pizlo
Comment 4 2016-04-07 11:38:47 PDT
Landed in https://trac.webkit.org/changeset/199166
Note You need to log in before you can comment on or make changes to this bug.