Bug 156352 - Rationalize the makeSpaceForCCall stuff
Summary: Rationalize the makeSpaceForCCall stuff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 130914
  Show dependency tree / graph
 
Reported: 2016-04-07 11:19 PDT by Filip Pizlo
Modified: 2016-04-07 11:38 PDT (History)
5 users (show)

See Also:

Attachments
the patch (7.97 KB, patch)
2016-04-07 11:24 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-07 11:19:39 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-04-07 11:24:38 PDT 
Created attachment 275901 [details]
the patch
Comment 2 Mark Lam 2016-04-07 11:29:28 PDT 
Comment on attachment 275901 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275901&action=review

r=me

> Source/JavaScriptCore/ChangeLog:18
> +        the old value of scratchGPR, but the condition woudln't necessarily trigger. So if the call

typo: /woudln't/wouldn't/

> Source/JavaScriptCore/ChangeLog:21
> +        Making room on the stack for a call is cheap operation. It's orders of magnitude cheaper

Missing "a" between "is cheap".
Comment 3 Filip Pizlo 2016-04-07 11:36:39 PDT 
(In reply to comment #2)
> Comment on attachment 275901 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=275901&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:18
> > +        the old value of scratchGPR, but the condition woudln't necessarily trigger. So if the call
> 
> typo: /woudln't/wouldn't/
> 
> > Source/JavaScriptCore/ChangeLog:21
> > +        Making room on the stack for a call is cheap operation. It's orders of magnitude cheaper
> 
> Missing "a" between "is cheap".

Thanks!
Comment 4 Filip Pizlo 2016-04-07 11:38:47 PDT 
Landed in https://trac.webkit.org/changeset/199166