WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156341
[JSC] Enable Concurrent JIT by default
https://bugs.webkit.org/show_bug.cgi?id=156341
Summary
[JSC] Enable Concurrent JIT by default
Yusuke Suzuki
Reported
2016-04-07 08:38:40 PDT
[JSCOnly] Enable Concurrent JIT
Attachments
Patch
(3.51 KB, patch)
2016-04-07 08:50 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(1.33 KB, patch)
2016-04-07 13:42 PDT
,
Yusuke Suzuki
fpizlo
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2016-04-07 08:50:09 PDT
Created
attachment 275890
[details]
Patch
Csaba Osztrogonác
Comment 2
2016-04-07 08:55:41 PDT
Comment on
attachment 275890
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=275890&action=review
> Source/WTF/wtf/Platform.h:773 > #if (OS(DARWIN) || PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64) > #define ENABLE_CONCURRENT_JIT 1 > #endif > +#if !(ENABLE(DFG_JIT) && USE(JSVALUE64)) > +#undef ENABLE_CONCURRENT_JIT > +#define ENABLE_CONCURRENT_JIT 0 > +#endif
Shouldn't we enable concurrent JIT always if ENABLE(DFG_JIT) && USE(JSVALUE64) ? Is there any platform disabling concurrent JIT intentionally?
Yusuke Suzuki
Comment 3
2016-04-07 09:24:20 PDT
Comment on
attachment 275890
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=275890&action=review
Thanks.
>> Source/WTF/wtf/Platform.h:773 >> +#endif > > Shouldn't we enable concurrent JIT always if ENABLE(DFG_JIT) && USE(JSVALUE64) ? > Is there any platform disabling concurrent JIT intentionally?
I've checked which port uses the concurrent JIT. OS(DARWIN) covers OSX and IOS. (And maybe, it includes IOS Simulator). PLATFORM(WIN) covers the Windows environment including Apple Win and WinCairo. And PLATFORM(EFL) & PLATFORM(GTK) covers the other existing ports. So, if I counted correctly, it seems that all the ports now uses the concurrent JIT, right?
Yusuke Suzuki
Comment 4
2016-04-07 13:18:54 PDT
Is there any port that does not want to enable Concurrent JIT when DFG & JSVALUE64 are enabled? If there is nothing, I'll attempt to change `(OS(DARWIN) || PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64)` to `ENABLE(DFG_JIT) && USE(JSVALUE64)`.
Filip Pizlo
Comment 5
2016-04-07 13:24:05 PDT
(In reply to
comment #4
)
> Is there any port that does not want to enable Concurrent JIT when DFG & > JSVALUE64 are enabled? > If there is nothing, I'll attempt to change `(OS(DARWIN) || PLATFORM(EFL) || > PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64)` to > `ENABLE(DFG_JIT) && USE(JSVALUE64)`.
OK!
Yusuke Suzuki
Comment 6
2016-04-07 13:40:35 PDT
(In reply to
comment #5
)
> (In reply to
comment #4
) > > Is there any port that does not want to enable Concurrent JIT when DFG & > > JSVALUE64 are enabled? > > If there is nothing, I'll attempt to change `(OS(DARWIN) || PLATFORM(EFL) || > > PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64)` to > > `ENABLE(DFG_JIT) && USE(JSVALUE64)`. > > OK!
That's nice!
Yusuke Suzuki
Comment 7
2016-04-07 13:42:34 PDT
Created
attachment 275924
[details]
Patch
Yusuke Suzuki
Comment 8
2016-04-08 00:08:22 PDT
Committed
r199218
: <
http://trac.webkit.org/changeset/199218
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug