Bug 156339 - FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible
Summary: FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-07 05:16 PDT by Antti Koivisto
Modified: 2016-04-07 07:22 PDT (History)
7 users (show)

See Also:


Attachments
patch (1.71 KB, patch)
2016-04-07 05:22 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-04-07 05:16:59 PDT
FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header at the top of the page has been rendered. Google's current design shows a 60 pixel high header almost instantly, with the actual search results coming in later.
Comment 1 Antti Koivisto 2016-04-07 05:17:37 PDT
<rdar://problem/24491381>
Comment 2 Antti Koivisto 2016-04-07 05:22:58 PDT
Created attachment 275884 [details]
patch
Comment 3 Andreas Kling 2016-04-07 06:04:50 PDT
Comment on attachment 275884 [details]
patch

Sweet hax. r=me
Comment 4 WebKit Commit Bot 2016-04-07 07:22:13 PDT
Comment on attachment 275884 [details]
patch

Clearing flags on attachment: 275884

Committed r199155: <http://trac.webkit.org/changeset/199155>
Comment 5 WebKit Commit Bot 2016-04-07 07:22:18 PDT
All reviewed patches have been landed.  Closing bug.