Bug 156337 – S390X and PPC64 architectures detection is wrong

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Tomas Popela]

After the https://bugs.webkit.org/show_bug.cgi?id=156015 was committed it showed that the PPC64 detection is wrong as on the CPU(PPC) path was activated even for PPC64. The thing is that GCC defines __ppc__ even on PPC64 and not just on PPC(32). The same applies for S390X.

$  gcc -dM -E - < /dev/null | grep PPC
#define _ARCH_PPCGR 1
#define __PPC64__ 1   <---
#define _ARCH_PPCSQ 1
#define _ARCH_PPC 1
#define __PPC__ 1     <---
#define _ARCH_PPC64 1

[Tomas Popela]

Created attachment 275880 [details]
Proposed patch

[Carlos Garcia Campos]

Comment on attachment 275880 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275880&action=review

> Source/WTF/ChangeLog:8
> +        After the https://bugs.webkit.org/show_bug.cgi?id=156015 was committed

Please, use the revision number here instead of (or in addition to) the bug. I usually grep rev numbers to see commits fixing regressions introduced in other commits, or follow ups, etc. It makes my life easier :-)

[Tomas Popela]

Created attachment 275883 [details]
Proposed patch

[Tomas Popela]

Created attachment 275885 [details]
Proposed patch

[WebKit Commit Bot]

Comment on attachment 275885 [details]
Proposed patch

Clearing flags on attachment: 275885

Committed r199366: <http://trac.webkit.org/changeset/199366>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.