Bug 156333 - [GTK] Rework the theming code for GTK+ 3.20
Summary: [GTK] Rework the theming code for GTK+ 3.20
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2016-04-07 01:55 PDT by Carlos Garcia Campos
Modified: 2016-04-11 04:10 PDT (History)
1 user (show)

See Also:

Patch (99.61 KB, patch)
2016-04-07 02:18 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-04-07 01:55:16 PDT
During the 3.19 GTK+ release cycle, the GTK+ css system was reworked, making themes and programs rendering themed widgets, incompatible with the new system. We were trying to fix our rendering every time GTK+ broke something, but we were just changing whatever it was needed to make our rendering look like current GTK+ with the default theme Adwaita. This means that our rendering will be broken for other themes or that changes in Adwaita can break our rendering. This solution was good enough to ensure WebKitGTK+ 2.12 looked good with GTK+ 3.20, but it doesn't work in the long term. We need to ensure that our theming code honors the new GTK+ CSS properties (max-width, min-width, margin, padding, border, ...) in all the cases, not only the cases where Adwaita uses them like we currently do.
Comment 1 Carlos Garcia Campos 2016-04-07 02:18:25 PDT
Created attachment 275871 [details]

Something similar is needed now for ScrollbarThemeGtk
Comment 2 Carlos Garcia Campos 2016-04-11 03:59:10 PDT
Committed r199292: <http://trac.webkit.org/changeset/199292>