Bug 156332 - [CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again
Summary: [CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-07 01:15 PDT by Fujii Hironori
Modified: 2016-04-07 09:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2016-04-07 01:33 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2016-04-07 01:15:28 PDT 
[CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again

In Source/WebKit/PlatformWin.cmake:

> add_custom_command(
>     OUTPUT ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h
>     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
>     COMMAND ${PERL_EXECUTABLE} ${WEBKIT_LIBRARIES_DIR}/tools/scripts/auto-version.pl ${DERIVED_SOURCES_WEBKIT_DIR}
>     VERBATIM)

The output path is not ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h, but ${DERIVED_SOURCES_WEBKIT_DIR}/include/autoversion.h.
Then Visual Studio thinks the output file deos not exist yet and trigger the command.
Comment 1 Fujii Hironori 2016-04-07 01:33:45 PDT 
Created attachment 275870 [details]
Patch
Comment 2 Brent Fulgham 2016-04-07 08:46:10 PDT 
Comment on attachment 275870 [details]
Patch

Oh! Thank you for noticing this. r=me.
Comment 3 Alex Christensen 2016-04-07 09:03:47 PDT 
Wow, I looked at this over and over again and couldn't see the problem.  Thanks!
Comment 4 WebKit Commit Bot 2016-04-07 09:37:42 PDT 
Comment on attachment 275870 [details]
Patch

Clearing flags on attachment: 275870

Committed r199158: <http://trac.webkit.org/changeset/199158>
Comment 5 WebKit Commit Bot 2016-04-07 09:37:46 PDT 
All reviewed patches have been landed.  Closing bug.