Bug 156304 - Rename MidpointState to WhitespaceCollapsingState
Summary: Rename MidpointState to WhitespaceCollapsingState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-06 12:00 PDT by Myles C. Maxfield
Modified: 2016-04-06 21:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (39.80 KB, patch)
2016-04-06 12:09 PDT, Myles C. Maxfield 		hyatt: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (872.78 KB, application/zip)
2016-04-06 12:41 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (532.97 KB, application/zip)
2016-04-06 12:48 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (451.43 KB, application/zip)
2016-04-06 12:50 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (353.38 KB, application/zip)
2016-04-06 13:00 PDT, Build Bot 		no flags Details
Patch for committing (42.08 KB, patch)
2016-04-06 21:12 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-04-06 12:00:50 PDT 
Rename MidpointState to WhitespaceCollapsingState
Comment 1 Myles C. Maxfield 2016-04-06 12:09:32 PDT 
Created attachment 275804 [details]
Patch
Comment 2 Build Bot 2016-04-06 12:41:29 PDT 
Comment on attachment 275804 [details]
Patch

Attachment 275804 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1110535

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-04-06 12:41:31 PDT 
Created attachment 275809 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-04-06 12:48:06 PDT 
Comment on attachment 275804 [details]
Patch

Attachment 275804 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1110548

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-04-06 12:48:09 PDT 
Created attachment 275811 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-04-06 12:50:49 PDT 
Comment on attachment 275804 [details]
Patch

Attachment 275804 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1110585

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-04-06 12:50:51 PDT 
Created attachment 275812 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-04-06 12:59:57 PDT 
Comment on attachment 275804 [details]
Patch

Attachment 275804 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1110597

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-04-06 13:00:00 PDT 
Created attachment 275813 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Dave Hyatt 2016-04-06 13:42:08 PDT 
Comment on attachment 275804 [details]
Patch

r=me
Comment 11 Myles C. Maxfield 2016-04-06 20:08:21 PDT 
Comment on attachment 275804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275804&action=review

> Source/WebCore/platform/text/BidiResolver.h:59
>      void ensureLineBoxInsideIgnoredSpaces(RenderObject* renderer)

This should take a reference.
Comment 12 Myles C. Maxfield 2016-04-06 21:12:10 PDT 
Created attachment 275861 [details]
Patch for committing
Comment 13 Myles C. Maxfield 2016-04-06 21:59:57 PDT 
Committed r199149: <http://trac.webkit.org/changeset/199149>