Bug 156286 - [JSC][JSCOnly] Enable SamplingProfiler by default
Summary: [JSC][JSCOnly] Enable SamplingProfiler by default
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-06 03:48 PDT by Yusuke Suzuki
Modified: 2016-04-07 08:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2016-04-06 04:05 PDT, Yusuke Suzuki 		mcatanzaro: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-04-06 03:48:51 PDT 
[JSC][JSCOnly] Enable SamplingProfiler by default
Comment 1 Yusuke Suzuki 2016-04-06 04:05:55 PDT 
Created attachment 275768 [details]
Patch
Comment 2 Yusuke Suzuki 2016-04-06 04:06:56 PDT 
The default RunLoop (And WorkQueue) implementation is WIP.
https://bugs.webkit.org/show_bug.cgi?id=155706
Comment 3 Csaba Osztrogonác 2016-04-07 06:18:27 PDT 
SamplingProfiler is already switched on in WebKitFeatures.cmake:
https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake#L173

This change would make it public option instead of private.
Comment 4 Michael Catanzaro 2016-04-07 07:10:25 PDT 
Comment on attachment 275768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275768&action=review

> Source/JavaScriptCore/runtime/SamplingProfiler.h:-37
> -#include <wtf/WorkQueue.h>

Why do you need to drop use of this header, if there are no code changes?
Comment 5 Yusuke Suzuki 2016-04-07 07:51:57 PDT 
Comment on attachment 275768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275768&action=review

Oops, I missed that. Thanks :)

>> Source/JavaScriptCore/runtime/SamplingProfiler.h:-37
>> -#include <wtf/WorkQueue.h>
> 
> Why do you need to drop use of this header, if there are no code changes?

r199092 changes the design of the SamplingProfiler. Now the SamplingProfiler works without WorkQueue.