Bug 156277 - Improve some other cases of context-sensitive inlining
Summary: Improve some other cases of context-sensitive inlining
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2016-04-05 20:55 PDT by Filip Pizlo
Modified: 2016-04-05 21:46 PDT (History)
5 users (show)

See Also:

the patch (11.84 KB, patch)
2016-04-05 21:03 PDT, Filip Pizlo
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-05 20:55:00 PDT
I found some simple improvements in the bytecode parser that greatly improve the chances of context-sensitive inlining happening by revealing the callee constant.
Comment 1 Filip Pizlo 2016-04-05 21:03:57 PDT
Created attachment 275744 [details]
the patch
Comment 2 Benjamin Poulain 2016-04-05 21:14:52 PDT
Comment on attachment 275744 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275744&action=review

> Source/JavaScriptCore/ChangeLog:32
> +        This is a 14% speed-up on Octane/raytrace.

On one hand, optimizing at the parser level is pretty weird.
On the other hand...14%!

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1176
> +        return;

You don't need the return.
Comment 3 Filip Pizlo 2016-04-05 21:46:39 PDT
Landed in http://trac.webkit.org/changeset/199093