WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156277
Improve some other cases of context-sensitive inlining
https://bugs.webkit.org/show_bug.cgi?id=156277
Summary
Improve some other cases of context-sensitive inlining
Filip Pizlo
Reported
2016-04-05 20:55:00 PDT
I found some simple improvements in the bytecode parser that greatly improve the chances of context-sensitive inlining happening by revealing the callee constant.
Attachments
the patch
(11.84 KB, patch)
2016-04-05 21:03 PDT
,
Filip Pizlo
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2016-04-05 21:03:57 PDT
Created
attachment 275744
[details]
the patch
Benjamin Poulain
Comment 2
2016-04-05 21:14:52 PDT
Comment on
attachment 275744
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=275744&action=review
> Source/JavaScriptCore/ChangeLog:32 > + This is a 14% speed-up on Octane/raytrace.
On one hand, optimizing at the parser level is pretty weird. On the other hand...14%!
> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1176 > + return;
You don't need the return.
Filip Pizlo
Comment 3
2016-04-05 21:46:39 PDT
Landed in
http://trac.webkit.org/changeset/199093
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug