Bug 156264 - Modern IDB: Make sure SQLite backing store records have a INTEGER PRIMARY KEY column
Summary: Modern IDB: Make sure SQLite backing store records have a INTEGER PRIMARY KEY...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 143193
  Show dependency treegraph
 
Reported: 2016-04-05 16:59 PDT by Brady Eidson
Modified: 2016-04-06 15:25 PDT (History)
6 users (show)

See Also:


Attachments
WIP (2.87 KB, application/octet-stream)
2016-04-05 17:21 PDT, Brady Eidson
no flags Details
Patch v1 (4.69 KB, patch)
2016-04-05 21:23 PDT, Brady Eidson
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (928.51 KB, application/zip)
2016-04-05 21:42 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.04 MB, application/zip)
2016-04-05 22:09 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (726.96 KB, application/zip)
2016-04-05 22:11 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (804.27 KB, application/zip)
2016-04-05 22:15 PDT, Build Bot
no flags Details
Patch v2 - Whoops (6.51 KB, patch)
2016-04-06 11:22 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-04-05 16:59:16 PDT
Modern IDB: Make sure SQLite backing store records have a PRIMARY KEY AUTOINCREMENT column

This is because the rowID will be needed to support Blobs in the database... but unless there's a PRIMARY KEY column the rowIDs might change (e.g. when vacuuming)
Comment 1 Brady Eidson 2016-04-05 17:05:56 PDT
INTEGER PRIMARY KEY, not AUTOINCREMENT.
Comment 2 Brady Eidson 2016-04-05 17:21:06 PDT
Created attachment 275725 [details]
WIP

WIP patch, untested (still building...)

But it should really be this easy.
Comment 3 Brady Eidson 2016-04-05 21:23:44 PDT
Created attachment 275745 [details]
Patch v1
Comment 4 Build Bot 2016-04-05 21:42:34 PDT
Comment on attachment 275745 [details]
Patch v1

Attachment 275745 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1107195

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-04-05 21:42:37 PDT
Created attachment 275750 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-04-05 22:09:45 PDT
Comment on attachment 275745 [details]
Patch v1

Attachment 275745 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1107304

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-04-05 22:09:47 PDT
Created attachment 275753 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-04-05 22:11:48 PDT
Comment on attachment 275745 [details]
Patch v1

Attachment 275745 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1107286

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-04-05 22:11:50 PDT
Created attachment 275754 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-04-05 22:15:05 PDT
Comment on attachment 275745 [details]
Patch v1

Attachment 275745 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1107283

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2016-04-05 22:15:08 PDT
Created attachment 275756 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Brady Eidson 2016-04-06 11:22:43 PDT
Created attachment 275786 [details]
Patch v2 - Whoops
Comment 13 WebKit Commit Bot 2016-04-06 15:25:39 PDT
Comment on attachment 275786 [details]
Patch v2 - Whoops

Clearing flags on attachment: 275786

Committed r199120: <http://trac.webkit.org/changeset/199120>
Comment 14 WebKit Commit Bot 2016-04-06 15:25:43 PDT
All reviewed patches have been landed.  Closing bug.