This is needed since r197688 makes use of it.
Created attachment 275714 [details] Patch A proposed patch addressing the issue
Attachment 275714 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1521: Extra space before ) [whitespace/parens] [2] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 275716 [details] Patch A proposed patch addressing the issue
Comment on attachment 275716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275716&action=review > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1505 > + if ((cond != Signed) && m_fixedWidth) > + m_assembler.nop(); To me, these 2 lines are not needed. > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1515 > + ASSERT_NOT_REACHED(); Very good idea to add this, but please use "RELEASE_ASSERT_NOT_REACHED" instead. > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1532 > + ASSERT_NOT_REACHED(); Ditto.
Created attachment 275777 [details] Patch New version addressing Julien's remarks. Thanks for the quick review!
Looks good to me :)
Comment on attachment 275777 [details] Patch r=me
Comment on attachment 275777 [details] Patch Clearing flags on attachment: 275777 Committed r199261: <http://trac.webkit.org/changeset/199261>
All reviewed patches have been landed. Closing bug.