WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
156255
Refactor Windows/GTK/EFL usage of addHTTPHeaderField to send an HTTPHeaderName instead of a String
https://bugs.webkit.org/show_bug.cgi?id=156255
Summary
Refactor Windows/GTK/EFL usage of addHTTPHeaderField to send an HTTPHeaderNam...
John Wilander
Reported
2016-04-05 15:24:06 PDT
During the
https://bugs.webkit.org/show_bug.cgi?id=155602
it was noted that Windows, GTK, and EFL call ResourceResponseBase::addHTTPHeaderField() with a String reference as the header name. We should refactor these pieces to instead use HTTPHeaderName::findHTTPHeaderName() and send a HTTPHeaderName enum value to esourceResponseBase::addHTTPHeaderField(). Thus, unknown header names can be handled where error handling makes more sense. The same goes for ResourceRequestBase::addHTTPHeaderField(). After this refactoring it should be possible to remove the addHTTPHeaderField() functions that receive HTTP header names as strings.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug