Bug 156243 – [iOS] media title sometimes remain in Control Center after tab is closed

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Remove audio/video title from Control Center as soon as a tab is closed.

[Eric Carlson]

<rdar://problem/20167445>

[Eric Carlson]

Created attachment 275690 [details]
Proposed patch

[Eric Carlson]

Created attachment 275691 [details]
Updated patch.

[Eric Carlson]

Created attachment 276154 [details]
Proposed patch

[WebKit Commit Bot]

Attachment 276154 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:274:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 276155 [details]
Updated Patch

[WebKit Commit Bot]

Attachment 276155 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 276155 [details]
Updated Patch

Attachment 276155 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1137491

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 276158 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 276173 [details]
Updated Patch.

[Darin Adler]

Comment on attachment 276173 [details]
Updated Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=276173&action=review

> Source/WebCore/html/HTMLMediaElement.h:738
> +    PlatformMediaSession::CharacteristicsFlags characteristics() const override;

Probably should say "final" instead of "override"; same for most other functions in the file.

> Source/WebCore/platform/audio/PlatformMediaSession.h:188
> +    virtual PlatformMediaSession::CharacteristicsFlags characteristics() const = 0;
> +

Extra blank line here; should not add that.

> Source/WebCore/platform/audio/PlatformMediaSessionManager.h:86
> +    virtual void clientCharacteristicsChanged(PlatformMediaSession&) { }
> +

Ditto.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:228
> +    Vector<PlatformMediaSession*> sessionList = sessions();

I think auto would be better here than writing out the vector type. Actually, we could evaluate the vector inside the for loop:

    for (auto session : sessions()) {

That would work with no local variable.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:230
> +    if (!sessionList.size())
> +        return nullptr;

This isn’t needed. It doesn’t optimize anything.

[Eric Carlson]

Created attachment 276231 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 276231 [details]
Patch for landing.

Clearing flags on attachment: 276231

Committed r199351: <http://trac.webkit.org/changeset/199351>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.