Bug 156241 - REGRESSION (r188591): thingiverse.com direct messaging UI is not rendered properly
Summary: REGRESSION (r188591): thingiverse.com direct messaging UI is not rendered pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-05 10:48 PDT by Myles C. Maxfield
Modified: 2016-04-06 23:33 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.48 KB, patch)
2016-04-05 10:52 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (708.37 KB, application/zip)
2016-04-05 11:44 PDT, Build Bot
no flags Details
Patch (10.87 KB, patch)
2016-04-05 15:05 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (4.55 KB, patch)
2016-04-06 19:02 PDT, Myles C. Maxfield
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-04-05 10:48:46 PDT
REGRESSION (r188591): thingiverse.com direct messaging UI is not rendered properly
Comment 1 Myles C. Maxfield 2016-04-05 10:52:51 PDT
Created attachment 275674 [details]
Patch
Comment 2 Build Bot 2016-04-05 11:44:45 PDT
Comment on attachment 275674 [details]
Patch

Attachment 275674 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1104755

New failing tests:
fast/text/zero-sized-fonts.html
Comment 3 Build Bot 2016-04-05 11:44:48 PDT
Created attachment 275680 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5
Comment 4 Myles C. Maxfield 2016-04-05 15:05:46 PDT
Created attachment 275699 [details]
Patch
Comment 5 Myles C. Maxfield 2016-04-06 18:50:21 PDT
Comment on attachment 275699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275699&action=review

This

> Source/WebCore/ChangeLog:9
> +        text-rendering: optimizeLegibility enables optical sizing. When using an optical

Font::platformWidthForGlyph() is the place that changed in r188591 and needs to be updated.
Comment 6 Myles C. Maxfield 2016-04-06 19:02:05 PDT
Created attachment 275846 [details]
Patch
Comment 7 Myles C. Maxfield 2016-04-06 22:19:59 PDT
Committed r199150: <http://trac.webkit.org/changeset/199150>
Comment 8 Jon Lee 2016-04-06 23:33:34 PDT
rdar://problem/25262213