Bug 156189 - Make FrameView's exposedRect an Optional<>
Summary: Make FrameView's exposedRect an Optional<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 16:56 PDT by Simon Fraser (smfr)
Modified: 2016-04-04 21:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.75 KB, patch)
2016-04-04 16:57 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-04-04 16:56:20 PDT
Make FrameView's exposedRect an Optional<>
Comment 1 Simon Fraser (smfr) 2016-04-04 16:57:17 PDT
Created attachment 275592 [details]
Patch
Comment 2 Tim Horton 2016-04-04 16:58:08 PDT
Comment on attachment 275592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275592&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:462
> +        FloatRect visibleRect = m_clipLayer ? FloatRect({ 0, 0 }, frameView.unscaledVisibleContentSizeIncludingObscuredArea()) : frameView.visibleContentRect();

Technically I think you can get away without the 0, 0 but I don't know if you should.
Comment 3 WebKit Commit Bot 2016-04-04 21:04:40 PDT
Comment on attachment 275592 [details]
Patch

Clearing flags on attachment: 275592

Committed r199038: <http://trac.webkit.org/changeset/199038>
Comment 4 WebKit Commit Bot 2016-04-04 21:04:43 PDT
All reviewed patches have been landed.  Closing bug.