When launching web inspector within MiniBrowser, an error shows up saying "Web Inspector encountered an internal error" The reason of this issue is that, universal access to file url is set to false so that an exception will be throw when inspector trying to access localstorage. Set it to true solves this problem. Mac porting of Minibrowser also sets it to true btw.
<rdar://problem/25539297>
Created attachment 275581 [details] Patch
Comment on attachment 275581 [details] Patch rs=me Note: in the future, we want to move off file:// URLs and use a custom scheme so the inspector process needs fewer sandbox entitlements.
Thanks. If that happens someday, I hope I could help on that.
So, is it good to merge?
Bill, You did not set commit-queue:? flag. https://webkit.org/contributing-code/#optional-use-of-the-webkit-commit-bot
Comment on attachment 275581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275581&action=review > Tools/MiniBrowser/win/MiniBrowser.cpp:199 > - m_prefsPrivate->setAllowUniversalAccessFromFileURLs(FALSE); > + m_prefsPrivate->setAllowUniversalAccessFromFileURLs(TRUE); Errr, why is MiniBrowser be setting this preference? I think it should be the Web Inspector on Windows that should be setting it. Is this a WebKit1 window, or WebKit2?
Comment on attachment 275581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275581&action=review >> Tools/MiniBrowser/win/MiniBrowser.cpp:199 >> + m_prefsPrivate->setAllowUniversalAccessFromFileURLs(TRUE); > > Errr, why is MiniBrowser be setting this preference? I think it should be the Web Inspector on Windows that should be setting it. Is this a WebKit1 window, or WebKit2? If this is WebKit1 could this preference be set in: Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp - WebInspectorClient::openLocalFrontend If this is WebKit2, other ports set this in their inspector page configuration in: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm - WebInspectorProxy::platformCreateInspectorPage Source/WebKit2/UIProcess/mac/WebInspectorProxyEfl.cpp - WebInspectorProxy::platformCreateInspectorPage Perhaps this should be added to other ports (gtk) as well. cq- while the question gets answered.
Thank you for review. WebKit1 Mac port has following code in Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm: > [preferences setAllowFileAccessFromFileURLs:YES]; > [preferences setAllowUniversalAccessFromFileURLs:YES];
Created attachment 278387 [details] Patch
Comment on attachment 278387 [details] Patch Clearing flags on attachment: 278387 Committed r200577: <http://trac.webkit.org/changeset/200577>
Nice! Thanks for re-addressing this!