Bug 156184 – [wincairo] web inspector failed to launch in MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Bill Ming]

When launching web inspector within MiniBrowser, an error shows up saying "Web Inspector encountered an internal error"
The reason of this issue is that, universal access to file url is set to false so that an exception will be throw when inspector trying to access localstorage.
Set it to true solves this problem. Mac porting of Minibrowser also sets it to true btw.

[Radar WebKit Bug Importer]

<rdar://problem/25539297>

[Bill Ming]

Created attachment 275581 [details]
Patch

[Blaze Burg]

Comment on attachment 275581 [details]
Patch

rs=me

Note: in the future, we want to move off file:// URLs and use a custom scheme so the inspector process needs fewer sandbox entitlements.

[Bill Ming]

Thanks. If that happens someday, I hope I could help on that.

[Bill Ming]

So, is it good to merge?

[Fujii Hironori]

Bill,

You did not set commit-queue:? flag.

https://webkit.org/contributing-code/#optional-use-of-the-webkit-commit-bot

[Joseph Pecoraro]

Comment on attachment 275581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275581&action=review

> Tools/MiniBrowser/win/MiniBrowser.cpp:199
> -    m_prefsPrivate->setAllowUniversalAccessFromFileURLs(FALSE);
> +    m_prefsPrivate->setAllowUniversalAccessFromFileURLs(TRUE);

Errr, why is MiniBrowser be setting this preference? I think it should be the Web Inspector on Windows that should be setting it. Is this a WebKit1 window, or WebKit2?

[Joseph Pecoraro]

Comment on attachment 275581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275581&action=review

>> Tools/MiniBrowser/win/MiniBrowser.cpp:199
>> +    m_prefsPrivate->setAllowUniversalAccessFromFileURLs(TRUE);
> 
> Errr, why is MiniBrowser be setting this preference? I think it should be the Web Inspector on Windows that should be setting it. Is this a WebKit1 window, or WebKit2?

If this is WebKit1 could this preference be set in:
Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp - WebInspectorClient::openLocalFrontend

If this is WebKit2, other ports set this in their inspector page configuration in:
Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm - WebInspectorProxy::platformCreateInspectorPage
Source/WebKit2/UIProcess/mac/WebInspectorProxyEfl.cpp - WebInspectorProxy::platformCreateInspectorPage

Perhaps this should be added to other ports (gtk) as well. cq- while the question gets answered.

[Fujii Hironori]

Thank you for review.
WebKit1 Mac port has following code in
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:

>    [preferences setAllowFileAccessFromFileURLs:YES];
>    [preferences setAllowUniversalAccessFromFileURLs:YES];

[Fujii Hironori]

Created attachment 278387 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 278387 [details]
Patch

Clearing flags on attachment: 278387

Committed r200577: <http://trac.webkit.org/changeset/200577>

[Joseph Pecoraro]

Nice! Thanks for re-addressing this!