Bug 156168 - CopiedBlock should be 16kB
Summary: CopiedBlock should be 16kB
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
Depends on:
Reported: 2016-04-04 09:23 PDT by Geoffrey Garen
Modified: 2016-04-06 23:41 PDT (History)
8 users (show)

See Also:

Patch (1.50 KB, patch)
2016-04-04 09:29 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-04-04 09:23:26 PDT
CopiedBlock should be 16kB
Comment 1 Geoffrey Garen 2016-04-04 09:29:28 PDT
Created attachment 275551 [details]
Comment 2 Mark Lam 2016-04-04 09:43:04 PDT
Comment on attachment 275551 [details]

Comment 3 Geoffrey Garen 2016-04-04 11:51:15 PDT
Comment on attachment 275551 [details]

Comment 4 WebKit Commit Bot 2016-04-04 12:41:32 PDT
Comment on attachment 275551 [details]

Clearing flags on attachment: 275551

Committed r199016: <http://trac.webkit.org/changeset/199016>
Comment 5 WebKit Commit Bot 2016-04-04 12:41:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Benjamin Poulain 2016-04-05 00:41:22 PDT
Something really curious happened with this: https://arewefastyet.com/#machine=29&view=single&suite=kraken&subtest=beat-detection

Any idea how to get back this win without the other regressions?
Comment 7 Geoffrey Garen 2016-04-05 10:52:16 PDT
Rolled out in <http://trac.webkit.org/changeset/199032>.

"Regressed Octane and Kraken on the perf bots."
Comment 8 Geoffrey Garen 2016-04-05 10:58:11 PDT
> Any idea how to get back this win without the other regressions?

I might be able to bring it back. I didn't quite do it the best way the first time because I forgot to consider aligned allocation requests, which still take the slow path.

I don't understand that graph though -- what does it say?
Comment 9 Geoffrey Garen 2016-04-06 19:08:17 PDT
Committed r199125: <http://trac.webkit.org/changeset/199125>
Comment 10 Geoffrey Garen 2016-04-06 20:33:46 PDT
Rolled out in <http://trac.webkit.org/changeset/199145>.

"Perf bots are down, so I can't re-land this right now."
Comment 11 Geoffrey Garen 2016-04-06 23:41:31 PDT
On Octane, there's no regression.

On Kraken:

    1% speedup on Mac Pro
    1% speedup on iPhone (+/- !%)
    1% regression on MacBook Pro
    1% regression on MacBook Air

That's enough of a mixed review that I think I'll leave this alone for now.