Bug 156164 - REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
Summary: REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some s...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
Depends on:
Reported: 2016-04-04 04:22 PDT by Alejandro G. Castro
Modified: 2016-04-04 09:12 PDT (History)
5 users (show)

See Also:

Patch (28.56 KB, patch)
2016-04-04 04:32 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2016-04-04 04:22:46 PDT
In that commit a new WEB_RTC flag was added but in some situations it was used WEBRTC, also it was not activated by default as expected. After that commit and because some idls were not compiled the commit r198833 did not add the required parameters in the webrtc idls, so we are going to fix also that.
Comment 1 Alejandro G. Castro 2016-04-04 04:32:56 PDT
Created attachment 275544 [details]
Comment 2 Eric Carlson 2016-04-04 06:54:43 PDT
Thanks for fixing this Alejandro!
Comment 3 Alejandro G. Castro 2016-04-04 08:23:13 PDT
(In reply to comment #2)
> Thanks for fixing this Alejandro!

You are welcome, thanks for your help with WebRTC.
Comment 4 WebKit Commit Bot 2016-04-04 09:12:39 PDT
Comment on attachment 275544 [details]

Clearing flags on attachment: 275544

Committed r199007: <http://trac.webkit.org/changeset/199007>
Comment 5 WebKit Commit Bot 2016-04-04 09:12:43 PDT
All reviewed patches have been landed.  Closing bug.