Bug 156162 - [css-grid] Fix positioned children in RTL
Summary: [css-grid] Fix positioned children in RTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2016-04-04 02:20 PDT by Manuel Rego Casasnovas
Modified: 2016-04-06 03:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (24.08 KB, patch)
2016-04-04 02:22 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch for landing (24.03 KB, patch)
2016-04-06 02:31 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-04-04 02:20:21 PDT 
[css-grid] Fix positioned children in RTL
Comment 1 Manuel Rego Casasnovas 2016-04-04 02:22:11 PDT 
Created attachment 275540 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2016-04-04 02:23:38 PDT 
This is a port of: https://codereview.chromium.org/1841073002/
Comment 3 Sergio Villar Senin 2016-04-06 02:18:56 PDT 
Comment on attachment 275540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275540&action=review

> LayoutTests/fast/css-grid-layout/grid-positioned-items-background-rtl-expected.html:2
> +<html>

Remove <html> and <body> tags which are not needed

> LayoutTests/fast/css-grid-layout/grid-positioned-items-background-rtl.html:2
> +<html>

Ditto.
Comment 4 Manuel Rego Casasnovas 2016-04-06 02:31:09 PDT 
Created attachment 275763 [details]
Patch for landing
Comment 5 Manuel Rego Casasnovas 2016-04-06 02:32:34 PDT 
Comment on attachment 275763 [details]
Patch for landing

Thanks for the review, applied suggested changes.
Comment 6 WebKit Commit Bot 2016-04-06 03:22:03 PDT 
Comment on attachment 275763 [details]
Patch for landing

Clearing flags on attachment: 275763

Committed r199098: <http://trac.webkit.org/changeset/199098>
Comment 7 WebKit Commit Bot 2016-04-06 03:22:07 PDT 
All reviewed patches have been landed.  Closing bug.